Add Tap to Add button in card form#12299
Merged
samer-stripe merged 1 commit intomasterfrom Feb 5, 2026
Merged
Conversation
Contributor
|
Diffuse output: APKDEXARSC |
samer-stripe
force-pushed
the
samer/tap-to-add-card-form-button
branch
from
30f1989 to
7667c3a
Compare
samer-stripe
commented
Feb 3, 2026
| ScanCardButtonUI( | ||
| enabled = enabled, | ||
| cardScanGoogleLauncher = cardScanLauncher | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
There's a large refactor here we can do for Scan card but it requires the foundations from this PR and a follow up PR. It's a relatively expensive engineering refactor but we should create a task to do it to make ScanCard a CardDetailsAction.
Collaborator
Author
|
Will also fix the strings task once approved! |
amk-stripe
reviewed
Feb 4, 2026
|
|
||
| fun shouldAutomaticallyLaunchCardScan(): Boolean { | ||
| return automaticallyLaunchedCardScanFormDataHelper?.shouldLaunchCardScanAutomatically == true | ||
| return cardDetailsAction == null && |
Collaborator
There was a problem hiding this comment.
why would we want to prevent launching card scan in this case? My expectation would be for TTA and automatically launching card scan to be very separate features
It would probably be confusing if someone wanted to launch card scan automatically and then enabling TTA prevented that from happening
Collaborator
Author
There was a problem hiding this comment.
It's because TTA will be launching automatically instead of card scan. This is implemented in #12300.
| } | ||
|
|
||
| @Test | ||
| fun `createFormElements has null cardDetailsAction when tap to add is not supported`() { |
Collaborator
There was a problem hiding this comment.
these tests feel a bit like they are testing implementation details -- why exactly do we care about this being null specifically? do we want a certain form element to be shown or not? could we test for that instead?
Collaborator
Author
There was a problem hiding this comment.
This is actually testing to ensure we have no card details action if tap to add is not supported which should be the case. In a future refactor, this would be replaced by either card scan or tap to add.
amk-stripe
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Tap to Add button in card form
Motivation
Allows for launching Tap to Add from the card form
Testing